-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72433/
-----------------------------------------------------------
(Updated June 3, 2020, 2:54 a.m.)
Review request for hive and Jesús Camacho Rodríguez.
Bugs: HIVE-23244
https://issues.apache.org/jira/browse/HIVE-23244
Repository: hive-git
Description
-------
Create View commands are not queries, but commands which have queries as a part
of them. Therefore a separate CreateViewAnalyzer is needed which uses
SemanticAnalyer to analyze it's query.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java d732004e51
parser/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 768a3a17a7
ql/src/java/org/apache/hadoop/hive/ql/ddl/DDLUtils.java b82fc5e91d
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/create/AbstractCreateViewAnalyzer.java
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/create/AbstractCreateViewDesc.java
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/create/AlterViewAsAnalyzer.java
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/create/AlterViewAsDesc.java
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/create/AlterViewAsOperation.java
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/create/CreateMaterializedViewDesc.java
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/create/CreateMaterializedViewOperation.java
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/create/CreateViewAnalyzer.java
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/create/CreateViewDesc.java
d1f36945fb
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/create/CreateViewOperation.java
f7952a5cc1
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplLoadTask.java 792e331884
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 377e8280e5
ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java da443f419c
ql/src/java/org/apache/hadoop/hive/ql/parse/QB.java 9d94b6e2dd
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 8238a2a4a2
ql/src/java/org/apache/hadoop/hive/ql/parse/StorageFormat.java 2350646c36
ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java 2f3fc6c50a
ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java c75829c272
ql/src/java/org/apache/hadoop/hive/ql/plan/LoadFileDesc.java 07bcef8ee3
ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java 2fb452bea5
ql/src/test/results/clientnegative/create_or_replace_view4.q.out 767cc77596
ql/src/test/results/clientnegative/create_view_failure3.q.out 8b79272f46
ql/src/test/results/clientnegative/create_view_failure5.q.out b7b3984292
ql/src/test/results/clientnegative/create_view_failure6.q.out 6d9fb6461d
ql/src/test/results/clientnegative/create_view_failure7.q.out 337dbe889e
ql/src/test/results/clientnegative/create_view_failure8.q.out cccb7e4b06
ql/src/test/results/clientnegative/create_view_failure9.q.out eac8cb489e
ql/src/test/results/clientnegative/selectDistinctStarNeg_1.q.out 9496e528e2
ql/src/test/results/clientpositive/llap/create_view.q.out 52b77c7505
ql/src/test/results/clientpositive/llap/create_view_translate.q.out
b5d464e716
ql/src/test/results/clientpositive/llap/explain_ddl.q.out 3cada1bbae
ql/src/test/results/clientpositive/llap/explainuser_1.q.out a2f241c470
ql/src/test/results/clientpositive/llap/lineage3.q.out c87d7c0c92
ql/src/test/results/clientpositive/llap/masking_mv.q.out 196688a17d
ql/src/test/results/clientpositive/llap/materialized_view_cluster.q.out
e34147d1da
ql/src/test/results/clientpositive/llap/materialized_view_create_rewrite_3.q.out
6e6ee34361
ql/src/test/results/clientpositive/llap/materialized_view_create_rewrite_4.q.out
23489244bd
ql/src/test/results/clientpositive/llap/materialized_view_create_rewrite_rebuild_dummy.q.out
d4bf2a6d8b
ql/src/test/results/clientpositive/llap/materialized_view_create_rewrite_time_window.q.out
dc0e861863
ql/src/test/results/clientpositive/llap/materialized_view_distribute_sort.q.out
cdcc356ae3
ql/src/test/results/clientpositive/llap/materialized_view_partition_cluster.q.out
4d6de9d8f7
ql/src/test/results/clientpositive/llap/materialized_view_partitioned.q.out
e463b3cba6
ql/src/test/results/clientpositive/llap/materialized_view_partitioned_3.q.out
8bdbf13d8a
ql/src/test/results/clientpositive/llap/selectDistinctStar.q.out 3fc0074ed4
ql/src/test/results/clientpositive/llap/union_top_level.q.out f846cb2fc1
ql/src/test/results/clientpositive/llap/vector_windowing.q.out ba31832201
ql/src/test/results/clientpositive/tez/explainanalyze_3.q.out 33546dd74f
ql/src/test/results/clientpositive/tez/explainuser_3.q.out f1c245b671
Diff: https://reviews.apache.org/r/72433/diff/3/
Changes: https://reviews.apache.org/r/72433/diff/2-3/
Testing
-------
All the tests are still running fine.
Thanks,
Miklos Gergely
