I will create new artifacts and restart the vote once HIVE-23215 is committed.
-Jesús On Tue, Apr 7, 2020 at 9:26 PM Jesus Camacho Rodriguez <jcama...@apache.org> wrote: > > The release -1 votes aren't vetos. You just need more +1's than -1's. > Thanks, I had not checked the bylaws and remembered this incorrectly :( > > -Jesús > > > > On Tue, Apr 7, 2020 at 1:42 PM Owen O'Malley <owen.omal...@gmail.com> > wrote: > >> Sorry Jesus for not getting back to you sooner. I started diving into >> ORC-577, but didn't finish. >> >> The release -1 votes aren't vetos. You just need more +1's than -1's. >> https://cwiki.apache.org/confluence/display/Hive/Bylaws#Bylaws-Voting >> >> That said, I'd ask for a different approach. Maybe we could pull the >> common >> fields out to a new class and make VectorizedRowBatch and the LLAP class >> inherit from it? >> >> This patch adds a bunch of stuff into storage-api that feels like it >> should >> be in LLAP instead of in storage-api. >> >> .. Owen >> >> On Tue, Apr 7, 2020 at 1:05 AM Jesus Camacho Rodriguez < >> jcama...@apache.org> >> wrote: >> >> > @Owen, will you be able to provide feedback on HIVE-22959 / ORC-577 >> > shortly? >> > The -1 constitutes a veto to the release, but it has been a week since >> we >> > received that vote and we are still awaiting feedback. >> > Currently the storage-api release and rest of Panos contribution are on >> > hold because of this. >> > >> > -Jesús >> > >> > >> > On Mon, Apr 6, 2020 at 10:31 PM Ashutosh Chauhan <hashut...@apache.org> >> > wrote: >> > >> > > +1 >> > > built and ran few tests locally. >> > > >> > > On Mon, Mar 30, 2020 at 2:21 PM Owen O'Malley <owen.omal...@gmail.com >> > >> > > wrote: >> > > >> > > > In evaluating this RC, I discovered HIVE-22959, which is the only >> patch >> > > in >> > > > this RC. >> > > > >> > > > I'm uncomfortable with the API added by HIVE-22959, because it is >> > > > duplicating a lot of the functionality from VectorizedRowBatch. I'll >> > look >> > > > at the motivating ORC-577 tomorrow, but for now I'm -1 on releasing >> it. >> > > > >> > > > .. Owen >> > > > >> > > > On Mon, Mar 30, 2020 at 1:18 PM Vineet G <vgargapa...@gmail.com> >> > wrote: >> > > > >> > > > > +1. Verified the signature, checksum and build. >> > > > > >> > > > > Vineet >> > > > > >> > > > > > On Mar 30, 2020, at 1:20 AM, Zoltan Haindrich <k...@rxd.hu> >> wrote: >> > > > > > >> > > > > > +1 >> > > > > > >> > > > > > * verified checksum/etc >> > > > > > * built and run tests locally >> > > > > > * built orc/master against it >> > > > > > * there doesn't seem to be a staged nexus repo for this - but it >> > > seems >> > > > > like earlier releases also doesn't had that; meanwhile >> > > > > >> > > > >> > > >> > >> https://repo.maven.apache.org/maven2/org/apache/hive/hive-storage-api/2.7.1/ >> > > > > seems to have them ; I assume it will be also uploaded there along >> > with >> > > > > sources/etc >> > > > > > >> > > > > > >> > > > > > On 3/24/20 9:33 PM, Jesus Camacho Rodriguez wrote: >> > > > > >> All, >> > > > > >> I'd like to make a storage-api release with HIVE-22959 >> > > > > >> <https://issues.apache.org/jira/browse/HIVE-22959> in it. >> > > > > >> Should we release the following artifacts as Hive Storage API >> > 2.7.2? >> > > > > >> tar: http://home.apache.org/~jcamacho/hive-storage-2.7.2/ >> > > > > >> tag: >> > > > > >> > https://github.com/apache/hive/releases/tag/storage-release-2.7.2-rc0 >> > > > > >> jiras: >> > > https://issues.apache.org/jira/projects/HIVE/versions/12347828 >> > > > > >> Thanks! >> > > > > >> -Jesús >> > > > > >> > > > > >> > > > >> > > >> > >> >
