[
https://issues.apache.org/jira/browse/HIVE-2716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185284#comment-13185284
]
Phabricator commented on HIVE-2716:
-----------------------------------
enis has commented on the revision "HIVE-2716 [jira] Move retry logic in
HiveMetaStore to a separe class".
Some context for the patch:
- All the retries in HiveMetaStore are actually retying methods of the
RawStore interface, which handles the jdbc connection. Thus an abstraction in
this layer makes more sense, and removes the clutter in the calling code.
- The RawStore is proxied to introduce an interceptor to carry out the
method invocations. Proxies of this type are used by most of the ORM frameworks
for transaction management, or retrying, logging, etc. Performance-wise, there
is a lot of layers already, like the thrift call -> jdo -> jdbc -> SQL parse ->
db engine that it won't make a major difference to use a dynamic proxy. Besides
they are not very slow as believed.
- HiveMetaStore.Command and executeWithRetry() is limited-provate to HCat,
and Hcat does not use these interfaces, so I just removed them. If we need
them, we can instead deprecate.
REVISION DETAIL
https://reviews.facebook.net/D1227
> Move retry logic in HiveMetaStore to a separe class
> ---------------------------------------------------
>
> Key: HIVE-2716
> URL: https://issues.apache.org/jira/browse/HIVE-2716
> Project: Hive
> Issue Type: Sub-task
> Components: Metastore
> Affects Versions: 0.9.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Attachments: HIVE-2716.D1227.1.patch
>
>
> In HIVE-1219, method retrying for raw store operation are introduced to
> handle jdo operations more robustly. However, the abstraction for the
> RawStore operations can be moved to a separate class implementing RawStore,
> which should clean up the code base for HiveMetaStore.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
