[ https://issues.apache.org/jira/browse/HIVE-2716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209975#comment-13209975 ]
Phabricator commented on HIVE-2716: ----------------------------------- enis has commented on the revision "HIVE-2716 [jira] Move retry logic in HiveMetaStore to a separe class". > What's the motivation for this patch? Is this change required by something on the HCat side? I created the issue and the patch while working on the HMS. The patch refactors the retry logic out of HMS. The Command wrapper inside HMS makes the code very hard to follow, and requires some ugly code for handling checked exceptions, and is error prone is someone forgets wrapping a new method in RawStore. REVISION DETAIL https://reviews.facebook.net/D1227 > Move retry logic in HiveMetaStore to a separe class > --------------------------------------------------- > > Key: HIVE-2716 > URL: https://issues.apache.org/jira/browse/HIVE-2716 > Project: Hive > Issue Type: Sub-task > Components: Metastore > Affects Versions: 0.9.0 > Reporter: Enis Soztutar > Assignee: Enis Soztutar > Attachments: HIVE-2716.D1227.1.patch, HIVE-2716.D1227.2.patch > > > In HIVE-1219, method retrying for raw store operation are introduced to > handle jdo operations more robustly. However, the abstraction for the > RawStore operations can be moved to a separate class implementing RawStore, > which should clean up the code base for HiveMetaStore. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira