Yeap, that's exactly what I had in mind :) Maybe the community should reconsider the rules for force pushing.
On Mon, Nov 30, 2020 at 5:25 PM László Bodor <[email protected]> wrote: > Hi! > > Amend means a force push in general (right?), which is something we are not > about to do. However, until no newer commits come in (as in this case, when > you immediately noticed the problem), we should consider amending/force > pushing. Not sure if this will be accepted/supported in the community, just > thinking aloud. > > Regards, > Laszlo Bodor > > > On Mon, 30 Nov 2020 at 16:59, Stamatis Zampetakis <[email protected]> > wrote: > > > Hello, > > > > Personal preferences but I think it would be better to allow such > > amendments instead of maintaining a separate file/commits for this > purpose. > > Cleaner history makes various operations easier (git bisect for instance) > > and the danger of losing commits is rather low (with all the commit > > notification emails in-place). > > > > Best, > > Stamatis > > > > On Mon, Nov 30, 2020 at 4:03 PM David <[email protected]> wrote: > > > > > Hey Peter, > > > > > > Ya, yes. The list of shame. Ha. > > > > > > Updated. Thanks. > > > > > > On Mon, Nov 30, 2020 at 9:50 AM Peter Vary <[email protected] > > > > > wrote: > > > > > > > Hi David, > > > > > > > > You are not the first and most probably not the last to do such a > > > mistake.. > > > > You should check the errata.txt for fixing these mistakes. > > > > > > > > Thanks, > > > > Peter > > > > > > > > > On Nov 30, 2020, at 15:33, David <[email protected]> wrote: > > > > > > > > > > Hello Team, > > > > > > > > > > I just merged PR #1703 to the master branch via GitHub. However, > > when > > > I > > > > > went to edit the commit message, I accidentally hit the "Enter" key > > > > instead > > > > > of the "Shift" key and the commit was merged with an improper > commit > > > > > message. > > > > > > > > > > It should read: > > > > > > > > > > HIVE-24423: Improve DbNotificationListener Thread (David Mollitor > > > > reviewed > > > > > by Naveen Gangam, Miklos Gergely) > > > > > > > > > > https://github.com/apache/hive/pull/1703 > > > > > > > > > > What's the best course of action here? Does someone have the power > > to > > > > > amend the message? > > > > > > > > > > Again, my apologies. Thanks. > > > > > > > > > > > > > >
