[
https://issues.apache.org/jira/browse/HIVE-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253597#comment-13253597
]
Phabricator commented on HIVE-2926:
-----------------------------------
cwsteinbach has commented on the revision "HIVE-2926 [jira] Expose some
information about the metastore through JMX".
INLINE COMMENTS
common/build.xml:30 I think we can remove the compile target defined in
common/build.xml and instead inherit the one defined in build-common.xml
build-common.xml:232 Please remove this change and instead define a src.dir
property above similar to test.src.dir.
common/src/java/org/apache/hadoop/hive/common/VersionInfo.java:83 The "-r"
prefix doesn't make sense for Git hashtags.
metastore/src/java/org/apache/hadoop/hive/metastore/MXBean.java:45 Change the
name to "isSaslEnabled()"
build-common.xml:223 I think it would be better to make saveVersion.sh
executable and call it directly, instead of invoking it via bash.
build-common.xml:241 It's not sufficient because we want to annotate all of
the JARs with this information.
As an aside, I think it would be preferable to write the generated
package-info.java file to the src.dir and update .gitignore/svn:ignore to
ignore these files. This approach obviates the need to run javac twice.
saveVersion.sh:49 These fields need to be parameterized since we're using
this script to annotate all of the JARs with package info.
saveVersion.sh:43 Please parameterize this.
REVISION DETAIL
https://reviews.facebook.net/D2655
BRANCH
hive-2926.1
> Expose some information about the metastore through JMX
> -------------------------------------------------------
>
> Key: HIVE-2926
> URL: https://issues.apache.org/jira/browse/HIVE-2926
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.9.0
>
> Attachments: HIVE-2926.D2637.1.patch, HIVE-2926.D2655.1.patch,
> HIVE-2926.D2655.2.patch, hive-2926.1.patch, metastore-jmx.patch
>
>
> Expose some information about the metastore through JMX
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
