[
https://issues.apache.org/jira/browse/HIVE-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253685#comment-13253685
]
Phabricator commented on HIVE-2926:
-----------------------------------
cwsteinbach has commented on the revision "HIVE-2926 [jira] Expose some
information about the metastore through JMX".
I applied the patch and tried building against a git repository. A couple
comments about the results:
* package-info.java files are currently generated for the common, contrib,
and hbase-handler subprojects. This file is not getting generated for other
subprojects because they currently define their own compile target. The
subprojects should either inherit the compile target defined in
build-commmon.xml, or else be modified to explicitly depend on the new pkg-info
target.
* Here's the contents of the package-info.java file in the hbase-handler
directory:
@HiveVersionAnnotation(version="0.10.0-SNAPSHOT",
revision="427ddadb8fb62de5f97b33e038e26fab80ec3653",
user="carl",
date="Fri Apr 13 12:08:12 PDT 2012",
repositoryUrl="git://Carls-MacBook-Pro.local/ on branch arcpatch-D2655")
package org.apache.hadoop.hive.common;
* I think we should use the abbreviated commit hash (%h) instead of the full
commit hash (%H).
* The repository URL is bogus. For Git it probably only makes sense to list
the commit hash (which is a GUID).
* The package should be org.apache.hadoop.hive.hbase-handler.
* Given a Hive JAR file, I think there should be some way of dumping the
version info and commit hash. This can be accomplished by including it in the
JAR manifest, or by defining a VersionInfo and associated main() which the JAR
file's Main-Class manifest attribute points to.
REVISION DETAIL
https://reviews.facebook.net/D2655
BRANCH
hive-2926.1
> Expose some information about the metastore through JMX
> -------------------------------------------------------
>
> Key: HIVE-2926
> URL: https://issues.apache.org/jira/browse/HIVE-2926
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.9.0
>
> Attachments: HIVE-2926.D2637.1.patch, HIVE-2926.D2655.1.patch,
> HIVE-2926.D2655.2.patch, hive-2926.1.patch, metastore-jmx.patch
>
>
> Expose some information about the metastore through JMX
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
