[ https://issues.apache.org/jira/browse/HIVE-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266905#comment-13266905 ]
Phabricator commented on HIVE-2975: ----------------------------------- ashutoshc has commented on the revision "HIVE-2975 [jira] Filter parsing does not recognize '!=' as operator and silently ignores invalid tokens". Other then those two comments, patch looks good. INLINE COMMENTS metastore/src/java/org/apache/hadoop/hive/metastore/parser/ExpressionTree.java:178 Can you also include Operator.NOTEQUALS2 in this expression so that it works for listTableNamesByFilter() api as well. metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java:1839 Can you also add a test for table filtering within a database. testTableFilter() method will be best suited for it. REVISION DETAIL https://reviews.facebook.net/D2931 > Filter parsing does not recognize '!=' as operator and silently ignores > invalid tokens > -------------------------------------------------------------------------------------- > > Key: HIVE-2975 > URL: https://issues.apache.org/jira/browse/HIVE-2975 > Project: Hive > Issue Type: Bug > Components: Metastore > Reporter: Thomas Weise > Assignee: Thomas Weise > Fix For: 0.9.1 > > Attachments: HIVE-2975.D2931.1.patch, HIVE-2975.D2931.2.patch > > > Should support operator as alternative to '<>' and should not produce false > positives on lexer errors. > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira