[
https://issues.apache.org/jira/browse/HIVE-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278321#comment-13278321
]
Phabricator commented on HIVE-2975:
-----------------------------------
ashutoshc has requested changes to the revision "HIVE-2975 [jira] Filter
parsing does not recognize '!=' as operator and silently ignores invalid
tokens".
INLINE COMMENTS
metastore/src/java/org/apache/hadoop/hive/metastore/parser/ExpressionTree.java:170
Comment needs to update to say only support "=" , "<>" and "!="
metastore/src/java/org/apache/hadoop/hive/metastore/parser/ExpressionTree.java:187
Instead of forming List<String> for printing correctly, I think its better to
add following method in Operator
public String toString() {
return o.op;
}
and then you can use original set in error message, which will print its
content correctly since Set extends from AbstractCollection.
Sorry for nitpicking !
REVISION DETAIL
https://reviews.facebook.net/D2931
BRANCH
svn
To: JIRA, ashutoshc, thw
> Filter parsing does not recognize '!=' as operator and silently ignores
> invalid tokens
> --------------------------------------------------------------------------------------
>
> Key: HIVE-2975
> URL: https://issues.apache.org/jira/browse/HIVE-2975
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Reporter: Thomas Weise
> Assignee: Thomas Weise
> Fix For: 0.9.1
>
> Attachments: HIVE-2975.D2931.1.patch, HIVE-2975.D2931.2.patch,
> HIVE-2975.D2931.3.patch, HIVE-2975.patch
>
>
> Should support operator as alternative to '<>' and should not produce false
> positives on lexer errors.
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
