[
https://issues.apache.org/jira/browse/HIVE-2804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269382#comment-13269382
]
Phabricator commented on HIVE-2804:
-----------------------------------
cwsteinbach has requested changes to the revision "HIVE-2804 [jira] Task log
retrieval fails on secure cluster".
Looks good overall. Please make the changes I requested and I will test and
commit. Thanks.
INLINE COMMENTS
shims/src/0.23/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java:46 If
this exception is thrown and we ignore it, then the next line is going to throw
an NPE since taskTrackerHttpURL will be null. We should make the caller handle
this exception instead of squelching it.
ql/src/java/org/apache/hadoop/hive/ql/exec/JobDebugger.java:108 Modify this
to also throw MalformedUrlException.
ql/src/java/org/apache/hadoop/hive/ql/exec/JobDebugger.java:103 Modify this
to catch Exception instead of IOException. We should also dump the exception
stack trace at this point, but that involves modify LogHelper. We'll save that
for another ticket.
REVISION DETAIL
https://reviews.facebook.net/D3057
BRANCH
HIVE-2804
> Task log retrieval fails on secure cluster
> ------------------------------------------
>
> Key: HIVE-2804
> URL: https://issues.apache.org/jira/browse/HIVE-2804
> Project: Hive
> Issue Type: Bug
> Components: Diagnosability, Query Processor, Security
> Reporter: Carl Steinbach
> Assignee: Zhenxiao Luo
> Attachments: HIVE-2804.1.patch.txt, HIVE-2804.2.patch.txt,
> HIVE-2804.D3057.1.patch, HIVE-2804.D3057.2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
