----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5381/#review8321 -----------------------------------------------------------
LICENSE <https://reviews.apache.org/r/5381/#comment17928> This is the BSD license template, not the actual license. Looks like the updated BSD license is available in the SQLLine CVS repository here: http://sqlline.cvs.sourceforge.net/viewvc/sqlline/LICENSE?view=markup NOTICE <https://reviews.apache.org/r/5381/#comment17929> Please change this to: This product includes/uses SQLLine (http://sqlline.sourceforge.net), Copyright (c) 2002, 2003, 2004, 2005 Marc Prud'hommeaux <m...@cornell.edu>. bin/ext/sqlline.sh <https://reviews.apache.org/r/5381/#comment17933> If no hostname is specified this script should probably run the driver in embedded mode (e.g. with a connect string equal to "jdbc:hive://", or see TestJdbcDriver for another example). bin/ext/sqlline.sh <https://reviews.apache.org/r/5381/#comment17932> The default HiveServer listen port is 10000. bin/ext/sqlline.sh <https://reviews.apache.org/r/5381/#comment17934> "-n foo -p bar"? Is it possible to modify this in order to make it possible for the user to pass options to SQLLine from the command line (e.g. --showWarnings, --outputformat, etc)? Why is "--silent" hardcoded here (and is this --silent=true or --silent=false)? bin/ext/sqlline.sh <https://reviews.apache.org/r/5381/#comment17943> I see this error message three times when I start the sqlline CLI: "Error: Method not supported (state=,code=0)" Any idea what's causing that? bin/ext/sqlline.sh <https://reviews.apache.org/r/5381/#comment17936> This prints out the SQLLine options, but I don't think those options are actually accessible if you start it using this script. bin/ext/util/execHiveCmd.sh <https://reviews.apache.org/r/5381/#comment17944> I don't think there's any benefit to putting this function here. Please move this back to sqlline.sh bin/ext/util/execHiveCmd.sh <https://reviews.apache.org/r/5381/#comment17945> We removed support for Hadoop versions < 20 several versions ago. Please remove this comment. bin/ext/util/execHiveCmd.sh <https://reviews.apache.org/r/5381/#comment17946> I dumped the values of these variables and they don't look right: CLASS = "-u" HIVE_OPTS = "" @ = "jdbc:hive://localhost:10000/default -n foo -p bar -d org.apache.hadoop.hive.jdbc.HiveDriver --silent" Including $HIVE_OPTS isn't appropriate in this circumstance. That environment variable is supposed to contain a list of "-hiveconf xx" settings, and the logic for processing these options is located in o.a.h.hive.cli.OptionsProcessor, which doesn't get invoked when you start SQLLine like this. One option for fixing this is to create a BeeLine java wrapper around SQLLine, and invoke SQLLine's main() method from BeeLine.main() after processing the -hiveconf options. ivy.xml <https://reviews.apache.org/r/5381/#comment17930> Why is this listed as a dependency both here and in cli/ivy.xml? I think this instance can be removed. ivy/libraries.properties <https://reviews.apache.org/r/5381/#comment17931> We should probably depend on version 1.0.2 assuming it works (http://sourceforge.net/projects/sqlline/files/sqlline/1.0.2/). - Carl Steinbach On June 18, 2012, 5:59 a.m., Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5381/ > ----------------------------------------------------------- > > (Updated June 18, 2012, 5:59 a.m.) > > > Review request for hive and Carl Steinbach. > > > Description > ------- > > The patch is to include command line SQL editor SQLLine into Hive > distribution. The tool can be invoked using 'hive --service sqlline <host> > [port]'. It requires the HiveServer running on the given host/port. > > The ivy dependencies are updated to include sqlline. The hive scripts are > updated to executing SQLLine with the required connection URL and other > command line options. The LICENSE and NOTICE files are updated to include > SQLLine information. > > > Diffs > ----- > > LICENSE 05085da > NOTICE 871fdde > bin/ext/sqlline.sh PRE-CREATION > bin/ext/util/execHiveCmd.sh 167cc40 > cli/ivy.xml ab949b1 > ivy.xml e83437e > ivy/ivysettings.xml fb6f4b8 > ivy/libraries.properties 8461da1 > > Diff: https://reviews.apache.org/r/5381/diff/ > > > Testing > ------- > > > Thanks, > > Prasad Mujumdar > >
