> On June 18, 2012, 6:01 p.m., Prasad Mujumdar wrote: > > LICENSE, line 421 > > <https://reviews.apache.org/r/5381/diff/1/?file=111540#file111540line421> > > > > This is the text posted on the SQLLine site site from where the hive > > build is downloading the jar. Since we are not using the source jar or > > making source changes, do we need to look at any other license terms than > > one listed for distribution ? > >
The problem is that this is the BSD license template. Until the fields are filled in it doesn't carry any weight as a legal document. I don't think it's a acceptable for us to fill those fields in on our own, and the only version of the license I could find is the one in version control. I think including that version here is our best bet. > On June 18, 2012, 6:01 p.m., Prasad Mujumdar wrote: > > bin/ext/sqlline.sh, line 23 > > <https://reviews.apache.org/r/5381/diff/1/?file=111542#file111542line23> > > > > hmm .. how about make that under a specific option like '--local or > > -l'. If an embedded mode is needed, then its better be invoked explicitly > > than overloading the host (or absence of it). > > I will log a separate ticket or subtask to address that if you agree. I think local mode should be the default in order to make the JDBC CLI an easy drop-in replacement for the current CLI. > On June 18, 2012, 6:01 p.m., Prasad Mujumdar wrote: > > ivy/libraries.properties, line 52 > > <https://reviews.apache.org/r/5381/diff/1/?file=111547#file111547line52> > > > > The directory and file names for version 1.0.2 are following different > > conventions that makes it hard to access it in ivy. > > I will followup with SQLLine community to address it if possible. Ok, sounds good. - Carl ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5381/#review8331 ----------------------------------------------------------- On June 18, 2012, 6:19 p.m., Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5381/ > ----------------------------------------------------------- > > (Updated June 18, 2012, 6:19 p.m.) > > > Review request for hive and Carl Steinbach. > > > Description > ------- > > The patch is to include command line SQL editor SQLLine into Hive > distribution. The tool can be invoked using 'hive --service sqlline <host> > [port]'. It requires the HiveServer running on the given host/port. > > The ivy dependencies are updated to include sqlline. The hive scripts are > updated to executing SQLLine with the required connection URL and other > command line options. The LICENSE and NOTICE files are updated to include > SQLLine information. > > > Diffs > ----- > > LICENSE 05085da > NOTICE 871fdde > bin/ext/sqlline.sh PRE-CREATION > cli/ivy.xml ab949b1 > ivy/ivysettings.xml fb6f4b8 > ivy/libraries.properties 8461da1 > > Diff: https://reviews.apache.org/r/5381/diff/ > > > Testing > ------- > > > Thanks, > > Prasad Mujumdar > >
