----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7042/ -----------------------------------------------------------
Review request for hive, Ashutosh Chauhan, Dmitriy Ryaboy, and Travis Crawford. Description ------- Right now TypeInfoUtils expects at least one field in a STRUCT, which is not always true, e.g., empty struct is allowed in Thrift. Modified TypeInfoUtils so that empty struct can be correctly processed. This addresses bug https://issues.apache.org/jira/browse/HIVE-3398. https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/HIVE-3398 Diffs ----- serde/if/test/complex.thrift 308b64c serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/Complex.java f5a2986 serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/EmptyStruct.java PRE-CREATION serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 6c07ab5 serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestThriftObjectInspectors.java 5f692fb serde/src/test/org/apache/hadoop/hive/serde2/thrift_test/CreateSequenceFile.java 8aef773 Diff: https://reviews.apache.org/r/7042/diff/ Testing ------- Thanks, Feng Peng
