[
https://issues.apache.org/jira/browse/HIVE-4733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13689354#comment-13689354
]
Phabricator commented on HIVE-4733:
-----------------------------------
brock has commented on the revision "HIVE-4733 [jira] HiveLockObjectData is not
compared properly".
Hi Navis,
Great catch on the ordering issue! I do have one minor question about the
change to ZooKeeperHiveLockManager. I am not expert there so I might be
totally off base. :)
Brock
INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java:448
Ignoring this exception I am less sure about. Too be sure I am no expert on
this class! :) But I read this method as:
delete mylock
if not parent.hasChildren():
delete parent
Is that your reading? If so, I wonder if we should let this exception be
thrown because it could be an indication of correctness issues?
REVISION DETAIL
https://reviews.facebook.net/D11277
BRANCH
HIVE-4733
ARCANIST PROJECT
hive
To: JIRA, ashutoshc, navis
Cc: brock
> HiveLockObjectData is not compared properly
> -------------------------------------------
>
> Key: HIVE-4733
> URL: https://issues.apache.org/jira/browse/HIVE-4733
> Project: Hive
> Issue Type: Bug
> Components: Locking
> Reporter: Navis
> Assignee: Navis
> Priority: Trivial
> Fix For: 0.12.0
>
> Attachments: HIVE-4733.D11277.1.patch, HIVE-4733.D11277.2.patch
>
>
> {noformat}
> ret = ret && (clientIp == null) ? target.getClientIp() == null :
> clientIp.equals(target.getClientIp());
> {noformat}
> seemed intended to be
> {noformat}
> ret = ret && (clientIp == null ? target.getClientIp() == null :
> clientIp.equals(target.getClientIp()));
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
