[
https://issues.apache.org/jira/browse/HIVE-4733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13692021#comment-13692021
]
Phabricator commented on HIVE-4733:
-----------------------------------
brock has commented on the revision "HIVE-4733 [jira] HiveLockObjectData is not
compared properly".
Hi Navis,
Once again, thanks for the patch! I expressed by thoughts in two comments in
ZooKeeperHiveLockManager.java.
Cheers!
Brock
INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java:448
Hi,
I am not a committer so what I say is certainly not binding! :) I've done a
decent amount of testing of this code via HIVE-4759 and I haven't hit the issue
where the zLock.getPath() has already been deleted. Therefor my preference
would be to leave this specific delete() as is.
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java:456
The fix around the parent delete "zkpClient.delete(name)" wasn't sufficient.
We could either do this in this JIRA or in a follow on JIRA but the
getChildren() call also needs to go in the try{ }
catch(KeeperException.NoNodeException).
REVISION DETAIL
https://reviews.facebook.net/D11277
BRANCH
HIVE-4733
ARCANIST PROJECT
hive
To: JIRA, ashutoshc, navis
Cc: brock
> HiveLockObjectData is not compared properly
> -------------------------------------------
>
> Key: HIVE-4733
> URL: https://issues.apache.org/jira/browse/HIVE-4733
> Project: Hive
> Issue Type: Bug
> Components: Locking
> Reporter: Navis
> Assignee: Navis
> Priority: Trivial
> Fix For: 0.12.0
>
> Attachments: HIVE-4733.D11277.1.patch, HIVE-4733.D11277.2.patch
>
>
> {noformat}
> ret = ret && (clientIp == null) ? target.getClientIp() == null :
> clientIp.equals(target.getClientIp());
> {noformat}
> seemed intended to be
> {noformat}
> ret = ret && (clientIp == null ? target.getClientIp() == null :
> clientIp.equals(target.getClientIp()));
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
