[
https://issues.apache.org/jira/browse/HIVE-4719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13692016#comment-13692016
]
Phabricator commented on HIVE-4719:
-----------------------------------
brock has commented on the revision "HIVE-4719 [jira] EmbeddedLockManager
should be shared to all clients".
Hi Navis,
Nice patch! What about moving the lock manager creation to a separate class,
say "LockManagerFactory"? I think that might be useful for a couple reasons:
1) Driver is already complex it'd be nice to remove some of the complexity,
if possible.
2) I could be wrong, but it looks like with the current patch, there is a
race condition where two HS2 clients could create a SharedLockManager at the
same time?
3) If using a factory method I think the additional interface of
SharedLockManager wouldn't be required.
What do you think about this proposal?
Cheers!
Brock
INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/Driver.java:201 I think the exception
should be passed into the second argument of the constructor so we don't lose
the stack trace.
REVISION DETAIL
https://reviews.facebook.net/D11229
To: JIRA, navis
Cc: brock
> EmbeddedLockManager should be shared to all clients
> ---------------------------------------------------
>
> Key: HIVE-4719
> URL: https://issues.apache.org/jira/browse/HIVE-4719
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Navis
> Assignee: Navis
> Priority: Trivial
> Attachments: HIVE-4719.D11229.1.patch
>
>
> Currently, EmbeddedLockManager is created per Driver instance, so locking has
> no meaning.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
