[
https://issues.apache.org/jira/browse/HIVE-4719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13694240#comment-13694240
]
Phabricator commented on HIVE-4719:
-----------------------------------
brock has commented on the revision "HIVE-4719 [jira] EmbeddedLockManager
should be shared to all clients".
Navis,
The patch looks good to me. I think the issue where creation of the
factory/manager can be taken forward in a follow JIRA since it's not related to
the patch itself!
Cheers!
Brock
INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/Driver.java:143 Ahh interesting! I
don't think Hive should continue on if it cannot create a lock manager but is
configured to use concurrency. However, I think we can handle this on a follow
on JIRA.
REVISION DETAIL
https://reviews.facebook.net/D11229
To: JIRA, navis
Cc: brock
> EmbeddedLockManager should be shared to all clients
> ---------------------------------------------------
>
> Key: HIVE-4719
> URL: https://issues.apache.org/jira/browse/HIVE-4719
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Navis
> Assignee: Navis
> Priority: Trivial
> Attachments: HIVE-4719.D11229.1.patch, HIVE-4719.D11229.2.patch
>
>
> Currently, EmbeddedLockManager is created per Driver instance, so locking has
> no meaning.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
