[
https://issues.apache.org/jira/browse/HIVE-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13715607#comment-13715607
]
Phabricator commented on HIVE-2702:
-----------------------------------
ashutoshc has requested changes to the revision "HIVE-2702 [jira]
listPartitionsByFilter only supports string partitions".
Some comments.
INLINE COMMENTS
metastore/src/java/org/apache/hadoop/hive/metastore/parser/ExpressionTree.java:161
Its better to say numeric type here, since we can also support byte and short
(both of which are valid hive types) as well.
metastore/src/java/org/apache/hadoop/hive/metastore/parser/ExpressionTree.java:262
As stated earlier, lets rename this method and variable as
doesOpSupportNumeric()
metastore/src/java/org/apache/hadoop/hive/metastore/parser/ExpressionTree.java:272
Why are you checking value instanceof Long here ? This parsing is not done via
grammar described in Filter.g
metastore/src/java/org/apache/hadoop/hive/metastore/parser/ExpressionTree.java:299
I presume this depends on DN upgrade, lets postpone it till than.
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:7699
HIVE-3059, I assume you want to say.
REVISION DETAIL
https://reviews.facebook.net/D11715
BRANCH
HIVE-2702
ARCANIST PROJECT
hive
To: JIRA, ashutoshc, sershe
> listPartitionsByFilter only supports string partitions for equals
> -----------------------------------------------------------------
>
> Key: HIVE-2702
> URL: https://issues.apache.org/jira/browse/HIVE-2702
> Project: Hive
> Issue Type: Bug
> Affects Versions: 0.8.1
> Reporter: Aniket Mokashi
> Assignee: Sergey Shelukhin
> Fix For: 0.12.0
>
> Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2702.D2043.1.patch,
> HIVE-2702.1.patch, HIVE-2702.D11715.1.patch, HIVE-2702.D11715.2.patch,
> HIVE-2702-v0.patch
>
>
> listPartitionsByFilter supports only non-string partitions. This is because
> its explicitly specified in generateJDOFilterOverPartitions in
> ExpressionTree.java.
> //Can only support partitions whose types are string
> if( ! table.getPartitionKeys().get(partitionColumnIndex).
>
> getType().equals(org.apache.hadoop.hive.serde.Constants.STRING_TYPE_NAME) ) {
> throw new MetaException
> ("Filtering is supported only on partition keys of type string");
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
