[
https://issues.apache.org/jira/browse/HIVE-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13721209#comment-13721209
]
Phabricator commented on HIVE-2702:
-----------------------------------
ashutoshc has accepted the revision "HIVE-2702 [jira] listPartitionsByFilter
only supports string partitions for equals".
+1 Looks good.
Few minor nits.
INLINE COMMENTS
metastore/src/java/org/apache/hadoop/hive/metastore/parser/Filter.g:160 Do u
want to name this as IntegralLiteral now ?
metastore/src/java/org/apache/hadoop/hive/metastore/parser/ExpressionTree.java:312
Do you instead want to say in this TODO that this will be dealt in HIVE-4888
ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java:2188 Do you want to
say for 2nd TODO that this will be dealt in HIVE-4888
REVISION DETAIL
https://reviews.facebook.net/D11847
BRANCH
HIVE-2702-2
ARCANIST PROJECT
hive
To: JIRA, ashutoshc, sershe
> listPartitionsByFilter only supports string partitions for equals
> -----------------------------------------------------------------
>
> Key: HIVE-2702
> URL: https://issues.apache.org/jira/browse/HIVE-2702
> Project: Hive
> Issue Type: Bug
> Affects Versions: 0.8.1
> Reporter: Aniket Mokashi
> Assignee: Sergey Shelukhin
> Fix For: 0.12.0
>
> Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2702.D2043.1.patch,
> HIVE-2702.1.patch, HIVE-2702.D11715.1.patch, HIVE-2702.D11715.2.patch,
> HIVE-2702.D11715.3.patch, HIVE-2702.D11847.1.patch, HIVE-2702.patch,
> HIVE-2702-v0.patch
>
>
> listPartitionsByFilter supports only non-string partitions. This is because
> its explicitly specified in generateJDOFilterOverPartitions in
> ExpressionTree.java.
> //Can only support partitions whose types are string
> if( ! table.getPartitionKeys().get(partitionColumnIndex).
>
> getType().equals(org.apache.hadoop.hive.serde.Constants.STRING_TYPE_NAME) ) {
> throw new MetaException
> ("Filtering is supported only on partition keys of type string");
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
