[
https://issues.apache.org/jira/browse/HIVE-4960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13724799#comment-13724799
]
Yin Huai commented on HIVE-4960:
--------------------------------
this failed test passed in my laptop. Seems the test query is not relevant to
my change.
> lastAlias in CommonJoinOperator is not used
> -------------------------------------------
>
> Key: HIVE-4960
> URL: https://issues.apache.org/jira/browse/HIVE-4960
> Project: Hive
> Issue Type: Improvement
> Reporter: Yin Huai
> Assignee: Yin Huai
> Priority: Minor
> Attachments: HIVE-4960.D11895.1.patch
>
>
> In CommonJoinOperator, there is object called lastAlias. The initial value of
> this object is 'null'. After tracing the usage of this object, I found that
> there is no place to change the value of this object. Also, it is only used
> in processOp in JoinOperator and MapJoinOperator as
> {code}
> if ((lastAlias == null) || (!lastAlias.equals(alias))) {
> nextSz = joinEmitInterval;
> }
> {\code}
> Since lastAlias will always be null, we will assign joinEmitInterval to
> nextSz every time we get a row. Later in processOp, we have
> {code}
> nextSz = getNextSize(nextSz);
> {\code}
> Because we reset the value of nextSz to joinEmitInterval every time we get a
> row, seems that getNextSize will not be used as expected.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
