[ 
https://issues.apache.org/jira/browse/HIVE-4960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13726647#comment-13726647
 ] 

Hudson commented on HIVE-4960:
------------------------------

FAILURE: Integrated in Hive-trunk-hadoop1-ptest #112 (See 
[https://builds.apache.org/job/Hive-trunk-hadoop1-ptest/112/])
HIVE-4960 : lastAlias in CommonJoinOperator is not used (Yin Huai via Ashutosh 
Chauhan) (hashutosh: 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1509314)
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java

                
> lastAlias in CommonJoinOperator is not used
> -------------------------------------------
>
>                 Key: HIVE-4960
>                 URL: https://issues.apache.org/jira/browse/HIVE-4960
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Yin Huai
>            Assignee: Yin Huai
>            Priority: Minor
>             Fix For: 0.12.0
>
>         Attachments: HIVE-4960.D11895.1.patch
>
>
> In CommonJoinOperator, there is object called lastAlias. The initial value of 
> this object is 'null'. After tracing the usage of this object, I found that 
> there is no place to change the value of this object. Also, it is only used 
> in processOp in JoinOperator and MapJoinOperator as
> {code}
> if ((lastAlias == null) || (!lastAlias.equals(alias))) {
>   nextSz = joinEmitInterval;
> }
> {\code}
> Since lastAlias will always be null, we will assign joinEmitInterval to 
> nextSz every time we get a row. Later in processOp, we have 
> {code}
> nextSz = getNextSize(nextSz);
> {\code}
> Because we reset the value of nextSz to joinEmitInterval every time we get a 
> row, seems that getNextSize will not be used as expected.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to