[
https://issues.apache.org/jira/browse/HIVE-5019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13735103#comment-13735103
]
Edward Capriolo commented on HIVE-5019:
---------------------------------------
When you see code like this:
{quote}
first = true;
for (int k = 0; k < columnSize; k++) {
- String newColName = i + "_VALUE_" + k; // any name, it does not matter.
+ newColName = i + "_VALUE_" + k; // any name, it does not matter.
if (!first) {
- valueColNames = valueColNames + ",";
- valueColTypes = valueColTypes + ",";
+ valueColNames.append(",");
+ valueColTypes.append(",");
}
- valueColNames = valueColNames + newColName;
- valueColTypes = valueColTypes + valueCols.get(k).getTypeString();
+ valueColNames.append(newColName);
+ valueColTypes.append(valueCols.get(k).getTypeString());
first = false;
{quote}
Can you replace it with StringUtil.join()
I have seen this about 4 places in hive. Maybe do that as a follow on.
> Use StringBuffer instead of += (issue 1)
> ----------------------------------------
>
> Key: HIVE-5019
> URL: https://issues.apache.org/jira/browse/HIVE-5019
> Project: Hive
> Issue Type: Sub-task
> Reporter: Benjamin Jakobus
> Assignee: Benjamin Jakobus
> Fix For: 0.12.0
>
> Attachments: HIVE-5019.1.patch.txt
>
>
> Issue 1 (use of StringBuffer over +=)
> java/org/apache/hadoop/hive/ql/optimizer/physical/GenMRSkewJoinProcessor.java
> java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java
> java/org/apache/hadoop/hive/ql/parse/PTFTranslator.java
> java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
> java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
> java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java
> java/org/apache/hadoop/hive/ql/plan/PlanUtils.java
> java/org/apache/hadoop/hive/ql/security/authorization/BitSetCheckedAuthorizationProvider.java
> java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsUtils.java
> java/org/apache/hadoop/hive/ql/udf/UDFLike.java
> java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSentences.java
> java/org/apache/hadoop/hive/ql/udf/generic/NumDistinctValueEstimator.java
> java/org/apache/hadoop/hive/ql/udf/ptf/NPath.java
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
