[ https://issues.apache.org/jira/browse/HIVE-5019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13735188#comment-13735188 ]
Edward Capriolo commented on HIVE-5019: --------------------------------------- The tests have to pass with +1. Then I comment on the ticket with +1 (Which I have not done yet because I have not had time for a full review) Then we commit the code Then the ticket is closed and we thank you. > Use StringBuffer instead of += (issue 1) > ---------------------------------------- > > Key: HIVE-5019 > URL: https://issues.apache.org/jira/browse/HIVE-5019 > Project: Hive > Issue Type: Sub-task > Reporter: Benjamin Jakobus > Assignee: Benjamin Jakobus > Fix For: 0.12.0 > > Attachments: HIVE-5019.1.patch.txt > > > Issue 1 (use of StringBuffer over +=) > java/org/apache/hadoop/hive/ql/optimizer/physical/GenMRSkewJoinProcessor.java > java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java > java/org/apache/hadoop/hive/ql/parse/PTFTranslator.java > java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java > java/org/apache/hadoop/hive/ql/plan/PlanUtils.java > java/org/apache/hadoop/hive/ql/security/authorization/BitSetCheckedAuthorizationProvider.java > java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsUtils.java > java/org/apache/hadoop/hive/ql/udf/UDFLike.java > java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSentences.java > java/org/apache/hadoop/hive/ql/udf/generic/NumDistinctValueEstimator.java > java/org/apache/hadoop/hive/ql/udf/ptf/NPath.java -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira