[
https://issues.apache.org/jira/browse/HIVE-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13755156#comment-13755156
]
Phabricator commented on HIVE-4914:
-----------------------------------
sershe has commented on the revision "HIVE-4914 [jira] filtering via partition
name should be done inside metastore server (implementation)".
INLINE COMMENTS
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java:496
TreeVisitor is part of the tree, and this is logically the part of
metastoresql... I think it makes sense to not expose it, it's a private class
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java:1887
that's in separate patch that is not in yet. will adjust either way when
resolving conflict
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java:1944 the
old methods are still there; old versions of hive client, or some other
clients, might call them. I will add this to the comment
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java:1965
this is old JDO code, it just moved
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java:1971
filed HIVE-5190
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java:5756 I
think this should be separate JIRA to refactor. I can move JDO partition
retrieval into separate class, but ideally it should be a refactoring patch
without code changes, otherwise it's hard to understand what broke if something
does
metastore/src/java/org/apache/hadoop/hive/metastore/parser/ExpressionTree.java:113
This class needs access to internals, and both are very small by themselves...
REVISION DETAIL
https://reviews.facebook.net/D12561
BRANCH
HIVE-4914-no-gen
ARCANIST PROJECT
hive
To: JIRA, ashutoshc, sershe
> filtering via partition name should be done inside metastore server
> (implementation)
> ------------------------------------------------------------------------------------
>
> Key: HIVE-4914
> URL: https://issues.apache.org/jira/browse/HIVE-4914
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HIVE-4914.01.patch, HIVE-4914.D12561.1.patch,
> HIVE-4914-only-no-gen.patch, HIVE-4914-only.patch, HIVE-4914.patch,
> HIVE-4914.patch, HIVE-4914.patch
>
>
> Currently, if the filter pushdown is impossible (which is most cases), the
> client gets all partition names from metastore, filters them, and asks for
> partitions by names for the filtered set.
> Metastore server code should do that instead; it should check if pushdown is
> possible and do it if so; otherwise it should do name-based filtering.
> Saves the roundtrip with all partition names from the server to client, and
> also removes the need to have pushdown viability checking on both sides.
> NO PRECOMMIT TESTS
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
