[
https://issues.apache.org/jira/browse/HIVE-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13761942#comment-13761942
]
Phabricator commented on HIVE-4914:
-----------------------------------
ashutoshc has requested changes to the revision "HIVE-4914 [jira] filtering via
partition name should be done inside metastore server (implementation)".
Also now we anyways have client side code for filter expression evaluation, I
think its easier to support backward compatibility. Client can catch thrift
equivalent of method not function exception while trying this function and than
degrade itself to old style client side evaluation.
INLINE COMMENTS
metastore/if/hive_metastore.thrift:289 Now that kryo support is checked in
trunk, I think its better to send kryo serialized expression in binary format
instead of xml serialized string.
REVISION DETAIL
https://reviews.facebook.net/D12561
To: JIRA, ashutoshc, sershe
> filtering via partition name should be done inside metastore server
> (implementation)
> ------------------------------------------------------------------------------------
>
> Key: HIVE-4914
> URL: https://issues.apache.org/jira/browse/HIVE-4914
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HIVE-4914.01.patch, HIVE-4914.02.patch,
> HIVE-4914.03.patch, HIVE-4914.D12561.1.patch, HIVE-4914.D12561.2.patch,
> HIVE-4914.D12561.3.patch, HIVE-4914.D12645.1.patch,
> HIVE-4914-only-no-gen.patch, HIVE-4914-only.patch, HIVE-4914.patch,
> HIVE-4914.patch, HIVE-4914.patch
>
>
> Currently, if the filter pushdown is impossible (which is most cases), the
> client gets all partition names from metastore, filters them, and asks for
> partitions by names for the filtered set.
> Metastore server code should do that instead; it should check if pushdown is
> possible and do it if so; otherwise it should do name-based filtering.
> Saves the roundtrip with all partition names from the server to client, and
> also removes the need to have pushdown viability checking on both sides.
> NO PRECOMMIT TESTS
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
