[
https://issues.apache.org/jira/browse/HIVE-5204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13757314#comment-13757314
]
Jason Dere commented on HIVE-5204:
----------------------------------
Use of the constants should be fine, those constants still exist. The issue
would be if anything else references the numericTypes Map, since I've changed
the keys that are stored in that map. However, numericTypes/numericTypeList
have package scope, not public scope, so I think we should be ok here.
> Change type compatibility methods to use PrimitiveCategory rather than
> TypeInfo
> -------------------------------------------------------------------------------
>
> Key: HIVE-5204
> URL: https://issues.apache.org/jira/browse/HIVE-5204
> Project: Hive
> Issue Type: Improvement
> Reporter: Jason Dere
> Assignee: Jason Dere
> Attachments: HIVE-5204.1.patch
>
>
> The type compatibility methods in the FunctionRegistry (getCommonClass,
> implicitConvertable) compare TypeInfo objects directly when its doing its
> type compatibility logic. This won't work as well with qualified types
> (varchar, char, decimal), because we will need different TypeInfo objects to
> represent varchar(5) and varchar(10), and the equality comparisons won't work
> anymore. We can change this logic to look at the PrimitiveCategory for the
> TypeInfo instead.
> NO PRECOMMIT TESTS - dependent on changes in HIVE-5203
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
