[
https://issues.apache.org/jira/browse/HIVE-5204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13759459#comment-13759459
]
Phabricator commented on HIVE-5204:
-----------------------------------
ashutoshc has accepted the revision "HIVE-5204 [jira] Change type compatibility
methods to use PrimitiveCategory rather than TypeInfo".
+1
REVISION DETAIL
https://reviews.facebook.net/D12687
BRANCH
HIVE-5204
ARCANIST PROJECT
hive
To: JIRA, ashutoshc, jdere
> Change type compatibility methods to use PrimitiveCategory rather than
> TypeInfo
> -------------------------------------------------------------------------------
>
> Key: HIVE-5204
> URL: https://issues.apache.org/jira/browse/HIVE-5204
> Project: Hive
> Issue Type: Improvement
> Reporter: Jason Dere
> Assignee: Jason Dere
> Attachments: HIVE-5204.1.patch, HIVE-5204.D12687.1.patch
>
>
> The type compatibility methods in the FunctionRegistry (getCommonClass,
> implicitConvertable) compare TypeInfo objects directly when its doing its
> type compatibility logic. This won't work as well with qualified types
> (varchar, char, decimal), because we will need different TypeInfo objects to
> represent varchar(5) and varchar(10), and the equality comparisons won't work
> anymore. We can change this logic to look at the PrimitiveCategory for the
> TypeInfo instead.
> NO PRECOMMIT TESTS - dependent on changes in HIVE-5203
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
