[
https://issues.apache.org/jira/browse/HIVE-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776680#comment-13776680
]
Phabricator commented on HIVE-4914:
-----------------------------------
sershe has commented on the revision "HIVE-4914 [jira] filtering via partition
name should be done inside metastore server (implementation)".
INLINE COMMENTS
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java:32
It is not here, this class exposes specific methods so it just gives you the
error. IncompatibleMetastoreException is thrown either directly by
get_partitions_by_expr, from server, or by listPartitionsByExpr.
Hive client cannot do handling as it doesn't know about expressions, filters,
etc.
PartitionPruner does the handling.
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java:1988 the
code is simply moved; jira for this is HIVE-5190
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:179 right
now, native-ness is implied when person calls the appropriate method, there's
already isNative call. Annotation will duplicate this information, and require
people to explicitly maintain it...
REVISION DETAIL
https://reviews.facebook.net/D12561
To: JIRA, ashutoshc, sershe
> filtering via partition name should be done inside metastore server
> (implementation)
> ------------------------------------------------------------------------------------
>
> Key: HIVE-4914
> URL: https://issues.apache.org/jira/browse/HIVE-4914
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: D12561.5.patch, D12561.6.patch, HIVE-4914.01.patch,
> HIVE-4914.02.patch, HIVE-4914.03.patch, HIVE-4914.04.patch,
> HIVE-4914.05.patch, HIVE-4914.06.patch, HIVE-4914.D12561.1.patch,
> HIVE-4914.D12561.2.patch, HIVE-4914.D12561.3.patch, HIVE-4914.D12561.4.patch,
> HIVE-4914.D12645.1.patch, HIVE-4914-only-no-gen.patch, HIVE-4914-only.patch,
> HIVE-4914.patch, HIVE-4914.patch, HIVE-4914.patch
>
>
> Currently, if the filter pushdown is impossible (which is most cases), the
> client gets all partition names from metastore, filters them, and asks for
> partitions by names for the filtered set.
> Metastore server code should do that instead; it should check if pushdown is
> possible and do it if so; otherwise it should do name-based filtering.
> Saves the roundtrip with all partition names from the server to client, and
> also removes the need to have pushdown viability checking on both sides.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
