> On Nov. 14, 2013, 2:43 a.m., Thejas Nair wrote: > > conf/hive-default.xml.template, line 891 > > <https://reviews.apache.org/r/15449/diff/2/?file=382964#file382964line891> > > > > "Should be a positive value" sounds like 0 will result in an error. I > > think it will be better to rephrase this as "Timeout is applicable only if > > the value is positive" > >
Ok. > On Nov. 14, 2013, 2:43 a.m., Thejas Nair wrote: > > service/src/java/org/apache/hive/service/cli/session/SessionManager.java, > > line 56 > > <https://reviews.apache.org/r/15449/diff/2/?file=382969#file382969line56> > > > > did you mean to use volatile and not transient ? Right. > On Nov. 14, 2013, 2:43 a.m., Thejas Nair wrote: > > service/src/java/org/apache/hive/service/cli/operation/Operation.java, line > > 85 > > <https://reviews.apache.org/r/15449/diff/2/?file=382966#file382966line85> > > > > I am not sure if we need an operation level timeout, I think the > > Session timeout will suffice for most use cases. > > But since this can be disabled through config value, I think it is OK. > > Operations seemed to be leaked sometimes when using JDBC. Just for the case. > On Nov. 14, 2013, 2:43 a.m., Thejas Nair wrote: > > service/src/java/org/apache/hive/service/cli/session/SessionManager.java, > > line 97 > > <https://reviews.apache.org/r/15449/diff/2/?file=382969#file382969line97> > > > > should we put "handleToSession.values()" in a synchronized block as > > well ? > > Right. Quite embarrassing. --a - Navis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15449/#review28855 ----------------------------------------------------------- On Nov. 18, 2013, 2:32 a.m., Navis Ryu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15449/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2013, 2:32 a.m.) > > > Review request for hive. > > > Bugs: HIVE-5799 > https://issues.apache.org/jira/browse/HIVE-5799 > > > Repository: hive-git > > > Description > ------- > > Need some timeout facility for preventing resource leakages from instable or > bad clients. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 32ab3d8 > conf/hive-default.xml.template c574ab5 > service/src/java/org/apache/hive/service/cli/OperationState.java 1ec6bd1 > service/src/java/org/apache/hive/service/cli/operation/Operation.java > 6f4b8dc > service/src/java/org/apache/hive/service/cli/session/HiveSession.java > 00058cc > service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java > cfda752 > service/src/java/org/apache/hive/service/cli/session/SessionManager.java > e262b72 > > Diff: https://reviews.apache.org/r/15449/diff/ > > > Testing > ------- > > Confirmed in the local environment. > > > Thanks, > > Navis Ryu > >
