> On Jan. 22, 2014, 7:02 a.m., Carl Steinbach wrote: > > service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java, > > line 397 > > <https://reviews.apache.org/r/15449/diff/2/?file=382968#file382968line397> > > > > I think the name of the method should accurately reflect the purpose it > > currently serves, as opposed to the purpose it may serve in the future.
ok - Navis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15449/#review32479 ----------------------------------------------------------- On Jan. 22, 2014, 4:42 a.m., Navis Ryu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15449/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2014, 4:42 a.m.) > > > Review request for hive. > > > Bugs: HIVE-5799 > https://issues.apache.org/jira/browse/HIVE-5799 > > > Repository: hive-git > > > Description > ------- > > Need some timeout facility for preventing resource leakages from instable or > bad clients. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 84ee78f > conf/hive-default.xml.template 66d22f9 > service/src/java/org/apache/hive/service/AbstractService.java c2a2b2d > service/src/java/org/apache/hive/service/cli/OperationState.java a023908 > service/src/java/org/apache/hive/service/cli/operation/Operation.java > 58a28b6 > > service/src/java/org/apache/hive/service/cli/operation/OperationManager.java > 345617c > service/src/java/org/apache/hive/service/cli/session/HiveSession.java > c8fb8ec > service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java > 445c858 > service/src/java/org/apache/hive/service/cli/session/SessionManager.java > bfe0e7b > > Diff: https://reviews.apache.org/r/15449/diff/ > > > Testing > ------- > > Confirmed in the local environment. > > > Thanks, > > Navis Ryu > >
