----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19149/#review36974 -----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java <https://reviews.apache.org/r/19149/#comment68194> Good we are deleting this. Previously I wondered why we need this when we gonna write to same metastore. metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnDbUtil.java <https://reviews.apache.org/r/19149/#comment68195> Do we need to synchronize this method? metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnDbUtil.java <https://reviews.apache.org/r/19149/#comment68192> Doing new HiveConf(), should be avoided if possible because: * Its an expensive operation, perf wise. * Other conf object in memory may have different values because of set commands. If you aren't able to get hold of hiveconf object, probably we need to make changes upstream to pass it all the way down here. metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnDbUtil.java <https://reviews.apache.org/r/19149/#comment68193> You created prop object but didn't make use of it. Don't you want to use that prop here, instead of new Properties? - Ashutosh Chauhan On March 12, 2014, 7:20 p.m., Alan Gates wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19149/ > ----------------------------------------------------------- > > (Updated March 12, 2014, 7:20 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-6606 > https://issues.apache.org/jira/browse/HIVE-6606 > > > Repository: hive-git > > > Description > ------- > > The metastore creates instances of TxnHandler. The constructor of this class > will fail if the config value for the jdbc string it expects is not defined > in the config file. > > Fixed this by changing transaction connection to use the same JDBC connection > string as the rest of the metastore. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java edc3d38 > metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnDbUtil.java > bbb0d28 > metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > 4441c2f > metastore/src/test/org/apache/hadoop/hive/metastore/txn/TestTxnHandler.java > 560fd5a > > Diff: https://reviews.apache.org/r/19149/diff/ > > > Testing > ------- > > Ran unit tests plus ran on cluster to assure issue not seen when transaction > handling turned off. > > > Thanks, > > Alan Gates > >
