> On March 12, 2014, 8:21 p.m., Ashutosh Chauhan wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnDbUtil.java, > > line 205 > > <https://reviews.apache.org/r/19149/diff/1/?file=517656#file517656line205> > > > > Do we need to synchronize this method?
This is really intended for use only in testing. It's only in the src area rather than test so that it can be picked up cross package for things like streaming and hive client tests. So I'm not too worried about synchronization or performance (for the next comment). I can add comments on the methods to make this clear so no one uses it when they shouldn't. > On March 12, 2014, 8:21 p.m., Ashutosh Chauhan wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnDbUtil.java, > > line 215 > > <https://reviews.apache.org/r/19149/diff/1/?file=517656#file517656line215> > > > > You created prop object but didn't make use of it. Don't you want to > > use that prop here, instead of new Properties? Oops. Will fix. - Alan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19149/#review36974 ----------------------------------------------------------- On March 12, 2014, 7:20 p.m., Alan Gates wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19149/ > ----------------------------------------------------------- > > (Updated March 12, 2014, 7:20 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-6606 > https://issues.apache.org/jira/browse/HIVE-6606 > > > Repository: hive-git > > > Description > ------- > > The metastore creates instances of TxnHandler. The constructor of this class > will fail if the config value for the jdbc string it expects is not defined > in the config file. > > Fixed this by changing transaction connection to use the same JDBC connection > string as the rest of the metastore. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java edc3d38 > metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnDbUtil.java > bbb0d28 > metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > 4441c2f > metastore/src/test/org/apache/hadoop/hive/metastore/txn/TestTxnHandler.java > 560fd5a > > Diff: https://reviews.apache.org/r/19149/diff/ > > > Testing > ------- > > Ran unit tests plus ran on cluster to assure issue not seen when transaction > handling turned off. > > > Thanks, > > Alan Gates > >
