----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19322/#review37478 -----------------------------------------------------------
beeline/src/java/org/apache/hive/beeline/BeeLine.java <https://reviews.apache.org/r/19322/#comment69011> I think we should prevent the exception from happening rather than capturing it after it happens, if this is possible. Also, I'm not sure if this will give enough error message to the user. - Xuefu Zhang On March 17, 2014, 9:41 p.m., Szehon Ho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19322/ > ----------------------------------------------------------- > > (Updated March 17, 2014, 9:41 p.m.) > > > Review request for hive and Xuefu Zhang. > > > Bugs: HIVE-6685 > https://issues.apache.org/jira/browse/HIVE-6685 > > > Repository: hive-git > > > Description > ------- > > Improving the error-handling in ArrayIndexOutOfBoundsException of Beeline. > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/BeeLine.java 3482186 > > Diff: https://reviews.apache.org/r/19322/diff/ > > > Testing > ------- > > Manual test. Now, in this scenario it will display the usage like: > > beeline -u > Usage: java org.apache.hive.cli.beeline.BeeLine > -u <database url> the JDBC URL to connect to > -n <username> the username to connect as > -p <password> the password to connect as > ... > > > Thanks, > > Szehon Ho > >
