> On March 17, 2014, 9:44 p.m., Xuefu Zhang wrote: > > beeline/src/java/org/apache/hive/beeline/BeeLine.java, line 573 > > <https://reviews.apache.org/r/19322/diff/1/?file=524852#file524852line573> > > > > I think we should prevent the exception from happening rather than > > capturing it after it happens, if this is possible. Also, I'm not sure if > > this will give enough error message to the user. > > Szehon Ho wrote: > Thanks Xuefu for looking at this. Yea thats a good point, but coulnd't > think of a way to do it cleanly without going into each if statement that > references args[i++..] and adding a case there. Is there any way you were > thinking?
There are standard commandline option processors. You may also refer to Hive CLI, which doesn't seem suffering from the same problem. - Xuefu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19322/#review37478 ----------------------------------------------------------- On March 17, 2014, 9:41 p.m., Szehon Ho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19322/ > ----------------------------------------------------------- > > (Updated March 17, 2014, 9:41 p.m.) > > > Review request for hive and Xuefu Zhang. > > > Bugs: HIVE-6685 > https://issues.apache.org/jira/browse/HIVE-6685 > > > Repository: hive-git > > > Description > ------- > > Improving the error-handling in ArrayIndexOutOfBoundsException of Beeline. > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/BeeLine.java 3482186 > > Diff: https://reviews.apache.org/r/19322/diff/ > > > Testing > ------- > > Manual test. Now, in this scenario it will display the usage like: > > beeline -u > Usage: java org.apache.hive.cli.beeline.BeeLine > -u <database url> the JDBC URL to connect to > -n <username> the username to connect as > -p <password> the password to connect as > ... > > > Thanks, > > Szehon Ho > >
