----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20399/#review40603 -----------------------------------------------------------
Patch is only adding partition columns from where clause not from select list. ql/src/test/results/clientpositive/column_access_stats.q.out <https://reviews.apache.org/r/20399/#comment73629> ds,hr is missing ql/src/test/results/clientpositive/column_access_stats.q.out <https://reviews.apache.org/r/20399/#comment73630> ds is missing - Ashutosh Chauhan On April 16, 2014, 1:07 a.m., Navis Ryu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20399/ > ----------------------------------------------------------- > > (Updated April 16, 2014, 1:07 a.m.) > > > Review request for hive. > > > Bugs: HIVE-6910 > https://issues.apache.org/jira/browse/HIVE-6910 > > > Repository: hive-git > > > Description > ------- > > From http://www.mail-archive.com/user@hive.apache.org/msg11324.html > > neededColumnIDs in TS is only for non-partition columns. But > ColumnAccessAnalyzer is calculating it on all columns. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMRTableScan1.java > 8c4b891 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java f285312 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java > 6bdf394 > ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnAccessAnalyzer.java > 74b595a > ql/src/java/org/apache/hadoop/hive/ql/parse/ProcessAnalyzeTable.java > c26be3c > ql/src/java/org/apache/hadoop/hive/ql/parse/PrunedPartitionList.java > d3268dd > ql/src/java/org/apache/hadoop/hive/ql/parse/QBParseInfo.java a7cec5d > ql/src/test/queries/clientpositive/column_access_stats.q fbf8bba > ql/src/test/results/clientpositive/column_access_stats.q.out 7eee4ba > > Diff: https://reviews.apache.org/r/20399/diff/ > > > Testing > ------- > > > Thanks, > > Navis Ryu > >