----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20399/#review43340 -----------------------------------------------------------
Ship it! - Ashutosh Chauhan On May 19, 2014, 7:05 a.m., Navis Ryu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20399/ > ----------------------------------------------------------- > > (Updated May 19, 2014, 7:05 a.m.) > > > Review request for hive. > > > Bugs: HIVE-6910 > https://issues.apache.org/jira/browse/HIVE-6910 > > > Repository: hive-git > > > Description > ------- > > From http://www.mail-archive.com/user@hive.apache.org/msg11324.html > > neededColumnIDs in TS is only for non-partition columns. But > ColumnAccessAnalyzer is calculating it on all columns. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java 58ed550 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ColumnPrunerProcFactory.java > 6a4dc9b > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMRTableScan1.java > 8c4b891 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java f285312 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java > 6bdf394 > ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnAccessAnalyzer.java > 74b595a > ql/src/java/org/apache/hadoop/hive/ql/parse/ProcessAnalyzeTable.java > c26be3c > ql/src/java/org/apache/hadoop/hive/ql/parse/PrunedPartitionList.java > d3268dd > ql/src/java/org/apache/hadoop/hive/ql/parse/QBParseInfo.java a7cec5d > ql/src/test/queries/clientpositive/column_access_stats.q fbf8bba > ql/src/test/results/clientpositive/column_access_stats.q.out d0cd195 > ql/src/test/results/compiler/plan/case_sensitivity.q.xml 7de7b4f > ql/src/test/results/compiler/plan/cast1.q.xml 41d3e7c > ql/src/test/results/compiler/plan/groupby1.q.xml 284f0a3 > ql/src/test/results/compiler/plan/groupby2.q.xml c8a178d > ql/src/test/results/compiler/plan/groupby3.q.xml b88aa68 > ql/src/test/results/compiler/plan/groupby4.q.xml cb1a99b > ql/src/test/results/compiler/plan/groupby5.q.xml 2fb8f20 > ql/src/test/results/compiler/plan/groupby6.q.xml c2d9a36 > ql/src/test/results/compiler/plan/input1.q.xml 2cf7a1d > ql/src/test/results/compiler/plan/input2.q.xml 7ecd903 > ql/src/test/results/compiler/plan/input20.q.xml 6cc5c81 > ql/src/test/results/compiler/plan/input3.q.xml 5d3d5a6 > ql/src/test/results/compiler/plan/input4.q.xml 0626e64 > ql/src/test/results/compiler/plan/input5.q.xml 036834e > ql/src/test/results/compiler/plan/input6.q.xml a94ee15 > ql/src/test/results/compiler/plan/input7.q.xml 80aac8d > ql/src/test/results/compiler/plan/input8.q.xml e683312 > ql/src/test/results/compiler/plan/input9.q.xml 7935d64 > ql/src/test/results/compiler/plan/input_part1.q.xml f89afe6 > ql/src/test/results/compiler/plan/input_testsequencefile.q.xml ca08c02 > ql/src/test/results/compiler/plan/input_testxpath.q.xml 2ba0b5e > ql/src/test/results/compiler/plan/input_testxpath2.q.xml 613752b > ql/src/test/results/compiler/plan/join1.q.xml f5a6123 > ql/src/test/results/compiler/plan/join2.q.xml 92292b7 > ql/src/test/results/compiler/plan/join3.q.xml c44132b > ql/src/test/results/compiler/plan/join4.q.xml c7257e8 > ql/src/test/results/compiler/plan/join5.q.xml bc62668 > ql/src/test/results/compiler/plan/join6.q.xml 1e1866d > ql/src/test/results/compiler/plan/join7.q.xml 5f65ddb > ql/src/test/results/compiler/plan/join8.q.xml bb9ec1f > ql/src/test/results/compiler/plan/sample1.q.xml be97dbe > ql/src/test/results/compiler/plan/sample2.q.xml d12bda4 > ql/src/test/results/compiler/plan/sample3.q.xml 01ae0c5 > ql/src/test/results/compiler/plan/sample4.q.xml d12bda4 > ql/src/test/results/compiler/plan/sample5.q.xml e27ac08 > ql/src/test/results/compiler/plan/sample6.q.xml c496604 > ql/src/test/results/compiler/plan/sample7.q.xml 0b39977 > ql/src/test/results/compiler/plan/subq.q.xml ad63615 > ql/src/test/results/compiler/plan/udf1.q.xml 3e944ad > ql/src/test/results/compiler/plan/udf4.q.xml 61434ea > ql/src/test/results/compiler/plan/udf6.q.xml c04aaba > ql/src/test/results/compiler/plan/udf_case.q.xml 40fe450 > ql/src/test/results/compiler/plan/udf_when.q.xml 6b73dbd > ql/src/test/results/compiler/plan/union.q.xml 34224e0 > > Diff: https://reviews.apache.org/r/20399/diff/ > > > Testing > ------- > > > Thanks, > > Navis Ryu > >
