----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23953/#review48791 -----------------------------------------------------------
It's a good idea, this looks neater, just had some comment and questions below. Thanks. data/scripts/q_test_init.sql <https://reviews.apache.org/r/23953/#comment85536> Is there a lot of work to implement using hiveconf variable like BeelineDriver did? If not, can we consider it? itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java <https://reviews.apache.org/r/23953/#comment85537> Can we pass these in as system properties? itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java <https://reviews.apache.org/r/23953/#comment85538> Same comment itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java <https://reviews.apache.org/r/23953/#comment85539> Sorry as I'm not that familiar , can you explain what these codes are for? - Szehon Ho On July 25, 2014, 10:49 p.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23953/ > ----------------------------------------------------------- > > (Updated July 25, 2014, 10:49 p.m.) > > > Review request for hive. > > > Bugs: HIVE-7519 > https://issues.apache.org/jira/browse/HIVE-7519 > > > Repository: hive-git > > > Description > ------- > > HIVE-7519: Refactor QTestUtil to remove its duplication with QFileClient for > qtest setup and teardown > > > Diffs > ----- > > data/scripts/q_test_cleanup.sql 31bd7205d85916ea352f715f2fd1462efc788208 > data/scripts/q_test_init.sql 12afdf391132e3fdd219aaa581e1f2e210d6dee2 > itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java > 2fefa067791bd74412c0b4efb697dc0d8bb03cd7 > > Diff: https://reviews.apache.org/r/23953/diff/ > > > Testing > ------- > > qTests. > > > Thanks, > > Ashish Singh > >
