> On July 29, 2014, 12:47 a.m., Szehon Ho wrote: > > itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java, line 147 > > <https://reviews.apache.org/r/23953/diff/3/?file=643975#file643975line147> > > > > Can we pass it in via the pom, like the other variables? I think it > > would be easier to find/change there if we ever refactor, in addition to > > being more consistent with the other vars.
Good point. Updated patch. - Ashish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23953/#review48954 ----------------------------------------------------------- On July 29, 2014, 11:46 p.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23953/ > ----------------------------------------------------------- > > (Updated July 29, 2014, 11:46 p.m.) > > > Review request for hive. > > > Bugs: HIVE-7519 > https://issues.apache.org/jira/browse/HIVE-7519 > > > Repository: hive-git > > > Description > ------- > > HIVE-7519: Refactor QTestUtil to remove its duplication with QFileClient for > qtest setup and teardown > > > Diffs > ----- > > ant/src/org/apache/hadoop/hive/ant/QTestGenTask.java > 33f227fe6eb0ea6df936775f02e4339ed496f6ad > data/conf/hive-site.xml fe8080addcadac4d52868866457dd038ea8d3d91 > data/conf/tez/hive-site.xml 0c99bb6914bd26de26cef77cf29cf37f070098dc > data/scripts/q_test_cleanup.sql 31bd7205d85916ea352f715f2fd1462efc788208 > data/scripts/q_test_init.sql 12afdf391132e3fdd219aaa581e1f2e210d6dee2 > hbase-handler/src/test/templates/TestHBaseCliDriver.vm > 01d596aa6591ddccff016436c7f31324b3896d00 > hbase-handler/src/test/templates/TestHBaseNegativeCliDriver.vm > 45c73389cb26d0d461080cc146c5d74aee199c4e > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestLocationQueries.java > 9edd7f30ff91bf7e01a2f52699192994fe0829f5 > itests/qtest/pom.xml 249956fc170c0cef2b8f98454fa952c498b9e29e > itests/util/src/main/java/org/apache/hadoop/hive/hbase/HBaseQTestUtil.java > 96a0de2829c2ec065b7835b12c4932d1278f9a84 > itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java > 2fefa067791bd74412c0b4efb697dc0d8bb03cd7 > ql/src/test/templates/TestCliDriver.vm > 4776c75c16329c7d3f6f1a032eef192d553cc3cc > ql/src/test/templates/TestCompareCliDriver.vm > f6f43b847fdd4039328632ef70d841fce9006d6d > ql/src/test/templates/TestNegativeCliDriver.vm > 991d5ac1b2fde66dbe60b39c853916577449b1a4 > ql/src/test/templates/TestParse.vm c476536940dc3a48000bf4e60e0b551ec7904d63 > ql/src/test/templates/TestParseNegative.vm > f62f17e4df5c1439d3787fc5c361804121bfcaf1 > > Diff: https://reviews.apache.org/r/23953/diff/ > > > Testing > ------- > > qTests. > > > Thanks, > > Ashish Singh > >
