[ https://issues.apache.org/jira/browse/HIVE-7946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14142828#comment-14142828 ]
Xuefu Zhang commented on HIVE-7946: ----------------------------------- Thanks for the good work. I only briefly went over the patch. One thing that caught my eyes was some code style issues. It would be nice to be consistent with existing code. Moreover, it'd be nice to have a review board link so that the review can be more effective. > CBO: Merge CBO changes to Trunk > ------------------------------- > > Key: HIVE-7946 > URL: https://issues.apache.org/jira/browse/HIVE-7946 > Project: Hive > Issue Type: Bug > Components: CBO > Reporter: Laljo John Pullokkaran > Assignee: Laljo John Pullokkaran > Attachments: HIVE-7946.1.patch, HIVE-7946.10.patch, > HIVE-7946.11.patch, HIVE-7946.12.patch, HIVE-7946.13.patch, > HIVE-7946.14.patch, HIVE-7946.2.patch, HIVE-7946.3.patch, HIVE-7946.4.patch, > HIVE-7946.5.patch, HIVE-7946.6.patch, HIVE-7946.7.patch, HIVE-7946.8.patch, > HIVE-7946.9.patch, HIVE-7946.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)