> On Nov. 1, 2014, 8:21 p.m., Brock Noland wrote: > > serde/src/java/org/apache/hadoop/hive/ql/io/sarg/PredicateLeaf.java, line 58 > > <https://reviews.apache.org/r/26968/diff/2/?file=745523#file745523line58> > > > > Perhaps we can change the Type enum to seperate out the types we need > > and then alter Orc to perform an type == String || type == CHAR || type > > VARCHAR?
Thanks for your suggestions, invoking the attribution "FilterPredicateType" will pollute the codes indeed. Update the patch by adding serveral adaptive methods for Parquet and Orc getting literal and types. Besides that, Decimal and Timestamp are still not able to create a FilterPredicate. Currently, it is allowed for Ints, Longs, Strings and Booleans. - cheng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26968/#review59500 ----------------------------------------------------------- On Oct. 21, 2014, 8:13 a.m., cheng xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26968/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2014, 8:13 a.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > HIVE-8122: convert ExprNode to Parquet supported FilterPredict > > > Diffs > ----- > > pom.xml c69498004cdf93d3955c863031858a2dde2d8ccc > > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/FilterPredicateLeafBuilder.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/LeafFilterFactory.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/read/ParquetRecordReaderWrapper.java > f5da46d392d8ac5f5589f66c37d567b1d3bd8843 > ql/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java > eeb9641545ed0ad69f3bbc9a8383697fc7efe37d > ql/src/test/org/apache/hadoop/hive/ql/io/sarg/TestSearchArgumentImpl.java > 831ef8c8ec64c270ef62d5336b4cc78d9e34b398 > serde/pom.xml 98e55061b6b3abe18030b0b8d3f511bd98bee5f7 > serde/src/java/org/apache/hadoop/hive/ql/io/sarg/PredicateLeaf.java > 616c6dbd1ec71ad178f41e8666bad2500e68e151 > serde/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgument.java > db0f0148e2a995534a4c1369fc4c542cd0b4e6ab > > Diff: https://reviews.apache.org/r/26968/diff/ > > > Testing > ------- > > local UT passed > > > Thanks, > > cheng xu > >
