----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26968/#review59711 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/FilterPredicateLeafBuilder.java <https://reviews.apache.org/r/26968/#comment101014> Can we capitalize the first letter of all javadocs in this class (including the top one)? ql/src/java/org/apache/hadoop/hive/ql/io/parquet/FilterPredicateLeafBuilder.java <https://reviews.apache.org/r/26968/#comment101013> Can we fix the spelling (buildPredicate?) ql/src/java/org/apache/hadoop/hive/ql/io/parquet/read/ParquetRecordReaderWrapper.java <https://reviews.apache.org/r/26968/#comment101018> Please format the if else (space before and after the parentheses). ql/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java <https://reviews.apache.org/r/26968/#comment101016> Please properly format this if-else case. serde/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgument.java <https://reviews.apache.org/r/26968/#comment101015> Can we capitalize this? Some minor formatting comments only. - Szehon Ho On Oct. 21, 2014, 8:13 a.m., cheng xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26968/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2014, 8:13 a.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > HIVE-8122: convert ExprNode to Parquet supported FilterPredict > > > Diffs > ----- > > pom.xml c69498004cdf93d3955c863031858a2dde2d8ccc > ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java > bdc2806895a4f4f550fc4d7fe64e8f6d56604f86 > > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/FilterPredicateLeafBuilder.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/LeafFilterFactory.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/read/ParquetRecordReaderWrapper.java > f5da46d392d8ac5f5589f66c37d567b1d3bd8843 > ql/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java > eeb9641545ed0ad69f3bbc9a8383697fc7efe37d > ql/src/test/org/apache/hadoop/hive/ql/io/sarg/TestSearchArgumentImpl.java > 831ef8c8ec64c270ef62d5336b4cc78d9e34b398 > serde/pom.xml 98e55061b6b3abe18030b0b8d3f511bd98bee5f7 > serde/src/java/org/apache/hadoop/hive/ql/io/sarg/PredicateLeaf.java > 616c6dbd1ec71ad178f41e8666bad2500e68e151 > serde/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgument.java > db0f0148e2a995534a4c1369fc4c542cd0b4e6ab > > Diff: https://reviews.apache.org/r/26968/diff/ > > > Testing > ------- > > local UT passed > > > Thanks, > > cheng xu > >