[EMAIL PROTECTED] writes:

>   Index: mod_include.c
>   ===================================================================
>   RCS file: /home/cvs/httpd-2.0/modules/filters/mod_include.c,v
>   retrieving revision 1.128
>   retrieving revision 1.129
>   diff -u -r1.128 -r1.129
>   --- mod_include.c   2001/08/23 15:35:50     1.128
>   +++ mod_include.c   2001/08/23 15:45:49     1.129
>   @@ -98,6 +98,29 @@
>    
>    #define BYTE_COUNT_THRESHOLD AP_MIN_BYTES_TO_WRITE
>    
>   +/* This function is used to split the brigade at the beginning of
>   + *   the tag and forward the pretag buckets before any substitution
>   + *   work is performed on the tag. This maintains proper ordering.
>   + */
>   +static int split_and_pass_pretag_buckets(apr_bucket_brigade **brgd, 

should be "apr_status_t" instead of "int", right?

>   +                                         include_ctx_t *cntxt, 
>   +                                         ap_filter_t *next)
>   +{
>   +    apr_bucket_brigade *tag_plus;
>   +    int rv;

apr_status_t rv;

>   +
>   +    if ((APR_BRIGADE_EMPTY(cntxt->ssi_tag_brigade)) &&
>   +        (cntxt->head_start_bucket != NULL)) {
>   +        tag_plus = apr_brigade_split(*brgd, cntxt->head_start_bucket);
>   +        rv = ap_pass_brigade(next, *brgd);
>   +        cntxt->bytes_parsed = 0;
>   +        *brgd = tag_plus;
>   +        if (rv != APR_SUCCESS) {
>   +            return rv;
>   +        }
>   +    }

besides not compiling cleanly this can't work dependably... you need
"return APR_SUCCESS;" here at the end of the function...

and then there is the issue Ryan raised...

-- 
Jeff Trawick | [EMAIL PROTECTED] | PGP public key at web site:
       http://www.geocities.com/SiliconValley/Park/9289/
             Born in Roswell... married an alien...

Reply via email to