On Thu, Oct 04, 2001 at 01:29:26PM -0700, Ryan Bloom wrote:
> > > - if (!ctx->remaining)
> > > - {
> > > + if (ctx->remaining <= 0) {
> >
> > No. =) Java weenie.
>
> Huh? How is this him being a Java weenie? Aaron has changed a check
> for !0 to a check for negative or 0. Those two checks are not equivalent.
> I'm not sure if this is a valid change or not yet, but I am wondering what the
> comment is about.
[To Justin]
Even if we were checking for zero/non-zero, I would want it to be
(ctx->remaining ==/!= 0)
We are not checking the boolean status of the variable, we are checking
the integer status. Shorthand does not equate to fewer instructions
and sometimes defeats readability.
-aaron
