From: "Thomas Eibner" <[EMAIL PROTECTED]>
Sent: Friday, December 21, 2001 8:26 AM


> A few months ago I proposed a patch (With Gunter Knauf's help) that
> would make my module mod_rpaf compile on Win32 and netware. It used
> the ap_update_vhost_from_headers function which wasn't correctly
> exported for it to compile. I proposed a patch to make that work,
> but was told that it would be nice to get the rest of the functions
> from httpd.exp exported too.

Hmmm.

Ok.  Here's my take.  Your patch breaks mod_ssl EAPI's patch (makes some
of it superfluous, actually) and breaks ALL binary compatibility.

Lets go for it :)

Here's my suggestion.  Do as you've advocated [based on httpd.exp].  But
DROP the ordinals on Win32.  The hash-lookup of the fn names that occurs
under the covers makes the differences nill.  Modules will continue to be 
backwards compatible from, oh, maybe version 1.3.14 or whenever we last 
horked with the structs.  But no older modules will be forward compatible, 
since they were bound by ordinal value.

I'll experiment and consider applying your patch.  Without a veto, and 
after Brad has reviewed this on Netware, I would be happy to commit the
patch, with the appropriate no-ordinals fix [probably as a seperate step.]

Bill





Reply via email to