Ryan, you are vetoing my veto. Consider this patch a veto of your 11/12 patch. I am open to suggestions to determine a compromise.
I need to replace core_in and core_out based on configuration. How can I do that with your patch in place? Bill ----- Original Message ----- From: "Ryan Bloom" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]> Sent: Sunday, January 27, 2002 3:05 PM Subject: RE: cvs commit: httpd-2.0/server/mpm/worker worker.c > > stoddard 02/01/27 04:52:08 > > > > Modified: . CHANGES > > include http_connection.h httpd.h > > modules/http http_core.c > > modules/proxy proxy_ftp.c proxy_http.c > > server connection.c core.c > > server/mpm/beos beos.c > > server/mpm/mpmt_os2 mpmt_os2_child.c > > server/mpm/netware mpm_netware.c > > server/mpm/perchild perchild.c > > server/mpm/prefork prefork.c > > server/mpm/winnt mpm_winnt.c > > server/mpm/worker worker.c > > Log: > > Remove the create_connection hook and put the client_socket back > into > > the > > conn_rec. The create_connection_hook has a design flaw that prevents > it > > from making decisions based on vhost information. > > -1. You can't back out a patch because it doesn't do something it > wasn't designed to do! That hook was meant to allow different filters > to be added based on the connection used, not based on the > configuration. If you want to do something based on the configuration, > you have to wait until the request has been read. Removing the socket > from the conn_rec has all sorts of advantages, not the least being that > it keeps people from using the socket without going through filters. > > Ryan > > >
