Okay.. I've added some little checks to get SSL-C to be recognized. Here's a
patch (relative to Geoff's patch) that does some checking.. I've added the
complete patch as attachment (also). If nobody has any objections, I'd like
to commit this.

Thanks
-Madhu



105,106c107,112
< +    dnl FIXME: we currently don't check anything for SSL-C
< +    AC_MSG_RESULT([OK, but I didn't really check])
---
> +    AC_TRY_COMPILE([#include <sslc.h>],
> +[#if !defined(SSLC_VERSION_NUMBER) || SSLC_VERSION_NUMBER < 0x2100
> +#error "invalid SSL-C version"
> +#endif],
> +    [AC_MSG_RESULT(OK)],
> +    [AC_MSG_ERROR([SSL-C Versions < 2.1 has not been tested])])
125,126c131,136
< +  AC_CHECK_LIB(crypto, SSLeay_version, [], [liberrors="yes"])
< +  AC_CHECK_LIB(ssl, SSL_CTX_new, [], [liberrors="yes"])
---
> +  if test "$ap_ssltk_type" = "openssl"; then
> +    AC_CHECK_LIB(crypto, SSLeay_version, [], [liberrors="yes"])
> +    AC_CHECK_LIB(ssl, SSL_CTX_new, [], [liberrors="yes"])
> +  else
> +    AC_CHECK_LIB(sslc, SSL_CTX_new, [], [liberrors="yes"])
> +  fi
152,155c162,168
< +  dnl (d) add "-lssl -lcrypto" to LIBS because restoring LIBS after
< +  dnl AC_CHECK_LIB() obliterates any flags AC_CHECK_LIB() added.
< +  APR_ADDTO(LIBS, [-lssl -lcrypto])
< +
---
> +  dnl (d) add "-lssl -lcrypto" OR "-lsslc" to LIBS because restoring LIBS
> +  dnl after AC_CHECK_LIB() obliterates any flags AC_CHECK_LIB() added.
> +  if test "$ap_ssltk_type" = "openssl"; then
> +    APR_ADDTO(LIBS, [-lssl -lcrypto])
> +  else
> +    APR_ADDTO(LIBS, [-lsslc])
> +  fi





-----Original Message-----
From: Geoff Thorpe [mailto:[EMAIL PROTECTED]
Sent: Wednesday, March 12, 2003 2:38 PM
To: [EMAIL PROTECTED]
Cc: Madhusudan Mathihalli
Subject: Re: [PATCH] openssl configuration (v2)


Hi Madhu,

Thanks for giving the latest incarnation a review.

* MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1) ([EMAIL PROTECTED])
wrote:
> 
> I tried the patch, and it seemed to work fine for me (and it's more
cleaner
> than what we have today).
> 
> - I don't know how SSL-C will be broken with this patch
> - Anybody out there using SSL-C ?
> - I have a patch to get SSL-C to work with mod_ssl.. I'll have to dust it
> out, before posting the patch.

If it helps move things along I'd be happy to sift through your existing
patch to see what it does. Although the two patches are unlikely to
cohabitate, it should be obvious enough from your patch what (if
anything) needs changing in mine to achieve SSL-C's needs, and I could
send an updated version with whatever I find? Ball, your court, etc :-)

As for testing SSL-C, can't we just approach Eric or Tim? Or do Covalent
or any other commecial Apache vendor use SSL-C? These would seem the
obvious avenues to me, but I don't want to pre-empt whatever
communications are already going w.r.t. SSL-C support. Just let me know
if I can help in some way.

> - any objections

Not from me, but then that should come as no surprise ...

Cheers,
Geoff

-- 
Geoff Thorpe
[EMAIL PROTECTED]
http://www.geoffthorpe.net/

Attachment: acinclude.m4.patch
Description: Binary data

Reply via email to