On Wed, 8 Oct 2003, Gregory (Grisha) Trubetskoy wrote:

> On Tue, 7 Oct 2003, Dirk-Willem van Gulik wrote:
>
> > Actualy I'd be happier if the strcmp() would becomce
> >
> >     if (user && !strcmp(r->user,user)
>
> Well here is a patch then. I tested it on 2.0.47 (mod_auth.c hasn't
> changed since (at least)).
>
> This patch prevents a segfault in cases where a module handles the
> check_user_id, returns OK but neglects to set r->user, AND there exists a
> "require user ..." directive.

Darn - I was hoping for a BIG patch which updated the API and module docs,
the example module, the header files.... this is soo pragmatic (and
backward compatible) that it feels like a 1.3. patch.

DW.

Reply via email to