On Thu, Mar 04, 2004 at 07:41:54AM +0100, Andr� Malo wrote:
> * "Mathihalli, Madhusudan" <[EMAIL PROTECTED]> wrote:
>
> >
> > Here's a slightly modified version of Joe's patch to
> > - not segfault if rewrite_ssl_var_lookup is not available (mod_ssl not
> > loaded)- use SSL environment variables as %{ENV:HTTPS} or
> > %{ENV:SSL_PROTOCOL}
>
> I'd prefer the %{SSL:...} variant and using ssl_var_lookup_ssl. All other
> stuff is already available in mod_rewrite. All the "logic" in ssl_var_lookup
> is just not necessary for this purpose.
I'm not really convinced about using ssl_var_lookup_ssl: that function
does not handle the "HTTPS" variable, and it would be potentially
confusing to users and hard to document since only some subset of the
SSL variables could be used. (it would also need a new optional
function in mod_ssl)
I'll commit the original patch with Madhu's fix to check
rewrite_ssl_lookup unless there are any strong objections.
joe
