Jeff Trawick wrote:

Wouldn't assuming that the directory is already there be sufficient
(and then create the directory structure on the error path)?  It looks
to me that we only assume the directory structure exists if we had
this very same file cached previously.



In a low traffic site, yes. In a very high traffic site, with lots of objects, the mkdir's kill you. After a "while," most of the directories will be created. However, bringing up a "fresh" server behind a very busy site is bad in this case. Perhaps, what mod_disk_cache does now is best and the pre-make directories script should be "contrib."


Also, any thought son how to handle Vary? I have a way to do it in our cache, but it seriously violates the RFC's. There is a config directive that defines what aspects of the request are used to generate the MD5 (virtual host, url, args, header values, environment values, etc.) and thats it. Only useful when you know a lot about the content being served, which is the case for a reverse proxy usually.


--
Brian Akins
Senior Systems Engineer
CNN Internet Technologies



Reply via email to