Re: [PATCH] mod_cache fixes: #7

[Bill Stoddard]

Justin Erenkrantz wrote:

--On Sunday, August 1, 2004 11:25 AM -0400 Bill Stoddard <[EMAIL PROTECTED]> wrote:

Too many changes in one patch. Break this up into multiple consumable in 15
minute patches and I'll review them.

* modules/experimental/mod_disk_cache.c (load_headers): Only validate that the
header file descriptor is available. (fd is an unnecessary check here.)

+1

Index: modules/experimental/mod_disk_cache.c
===================================================================
RCS file: /home/cvs/httpd-2.0/modules/experimental/mod_disk_cache.c,v
retrieving revision 1.52
diff -u -r1.52 mod_disk_cache.c
--- modules/experimental/mod_disk_cache.c 18 Mar 2004 21:40:12 -0000 1.52
+++ modules/experimental/mod_disk_cache.c 1 Aug 2004 08:24:52 -0000
@@ -465,7 +475,7 @@
apr_table_t * tmp;

    /* This case should not happen... */
-    if (!dobj->fd || !dobj->hfd) {
+    if (!dobj->hfd) {
        /* XXX log message */
        return APR_NOTFOUND;
    }